Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Resource] use a more appropriate response code on foreign key constraint violation exception #5166

Merged
merged 1 commit into from
Jun 2, 2016
Merged

[Resource] use a more appropriate response code on foreign key constraint violation exception #5166

merged 1 commit into from
Jun 2, 2016

Conversation

bendavies
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Related tickets
License MIT

500 is totally wrong. 409 seems to make the most sense to me.
https://httpstatuses.com/409

@pjedrzejewski pjedrzejewski merged commit 3aef23f into Sylius:master Jun 2, 2016
@pjedrzejewski
Copy link
Member

Thanks Ben, makes sense!

@bendavies
Copy link
Contributor Author

thanks @pjedrzejewski

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bendavies @pjedrzejewski