Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed an incorrect encoding causing an exception when it locale was used #520

Merged
merged 3 commits into from
Nov 2, 2013

Conversation

marcoalbarelli
Copy link
Contributor

No description provided.

@stloyd
Copy link
Contributor

stloyd commented Nov 2, 2013

Strange, for me that character rendered as: https://github.com/Sylius/Sylius/pull/513/files#diff-5

@marcoalbarelli
Copy link
Contributor Author

With the cfe987f version I get:
An exception has been thrown during the rendering of a template ("An error occurred while reading "/home/marco/PhpstormProjects/sylius/src/Sylius/Bundle/AddressingBundle/Resources/translations/messages.it.xlf": Input is not proper UTF-8, indicate encoding !
Bytes: 0xE0 0x3C 0x2F 0x74
") in SyliusWebBundle:Frontend:layout.html.twig at line 9.

With the proposed version I don't get exceptions

hexdump of your commit is:
00000150 20 20 20 3c 74 61 72 67 65 74 3e 43 69 74 74 e0 | Citt.|
and e0 is not UTF-8 for à

hexdump of my commit is
00000150 20 20 20 3c 74 61 72 67 65 74 3e 43 69 74 74 c3 | Citt.|
00000160 a0 3c 2f 74 61 72 67 65 74 3e 0a 20 20 20 20 20 |.. |
and c3a0 should be the correct UTF8 code for à:
http://www.utf8-chartable.de/unicode-utf8-table.pl?number=1024&utf8=0x

I tend to suspect your system's encoding may be the culprit, but UTF8 encoding quirks are always hard to swat

stloyd added a commit that referenced this pull request Nov 2, 2013
Fixed an incorrect encoding causing an exception when it locale was used
@stloyd stloyd merged commit 5bc440b into Sylius:master Nov 2, 2013
@stloyd
Copy link
Contributor

stloyd commented Nov 2, 2013

Ok, merged, thanks Marco!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants