[Bug Fix][ShippingBundle] Default shipping method choice form type set to correct class #5221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…this type since it is overriden in the services.xml; This will prevent some future headaches for other people trying to use standalone shipping bundle.
|
Should I close this in favor of #5216? |
|
@steffenbrem Let's keep it open until we merge #5216 to make sure this is fixed. |
|
This has been fixed in #5216 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set correct default form choice type for shipping method. It expects this type since it is overriden in the services.xml (https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/ShippingBundle/Resources/config/services.xml#L74); This will prevent some future headaches for other people trying to use standalone shipping bundle.