Add SKU to product form #524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds reasonable... can you also remove all those classes that not exist in Bootstrap 3 (i.e. |
|
@stloyd I removed all the useless bootstrap css classes. But not sure this is what you wanted... |
| {{ form_row(form.name, {'attr': {'class': 'input-large'}}) }} | ||
| {{ form_row(form.description, {'attr': {'class': 'input-xlarge'}, 'rows': 5}) }} | ||
| {{ form_row(form.name) }} | ||
| {{ form_row(form.description, {'attr': {'rows': 5}) }} |
There was a problem hiding this comment.
Missing } here. (see travis, 500 on this page)
|
@stloyd, OK no pb |
|
i have set sku as a property to move forward but hopefully there is a simple way to update this later on |
|
@stloyd it should be OK. I just removed remaining useless Bootstrap2 classes |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know why but it's currently impossible to set a SKU to a main product.