[Shipping] Removed unneeded composite resolver interface #5259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
the
Enhancement
|
|
||
| /** | ||
| * @author Arnaud Langlade <arn0d.dev@gamil.com> | ||
| */ | ||
| class ShippingMethodChoiceTypeSpec extends ObjectBehavior | ||
| { | ||
| function let( | ||
| CompositeMethodsResolverInterface $compositeMethodsResolver, | ||
| MethodsResolverInterface $compositeMethodsResolver, |
There was a problem hiding this comment.
This variable is called $compositeMethodsResolver but the interface is now MethodsResolverInterface. It's just a small thing but this now makes it seem like a composite methods resolver is expected to be injected in, even though that won't necessarily be true.
Similar occurrences elsewhere.
|
@CarwynNelson Thanks for the review! :) |
| * @param ServiceRegistryInterface $calculators | ||
| * @param RepositoryInterface $repository | ||
| */ | ||
| public function __construct( | ||
| CompositeMethodsResolverInterface $compositeShippingMethodsResolver, | ||
| MethodsResolverInterface $compositeShippingMethodsResolver, |
There was a problem hiding this comment.
Then we should also rename the variable.
Zales0123
force-pushed
the
remove-unneeded-composite-methods-resolver-interface
branch
from
53b89e7
to
39297e2
Compare
|
Thank you Mateusz. :) |
Zales0123
deleted the
remove-unneeded-composite-methods-resolver-interface
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change proposed in this comment.