Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct payum version constraints for SyliusPayumBundle #5278

Merged
merged 1 commit into from
Jul 20, 2016

Conversation

videni
Copy link
Contributor

@videni videni commented Jun 17, 2016

Q A
Bug fix? no
New feature? no
BC breaks? no
License MIT

@videni
Copy link
Contributor Author

videni commented Jun 17, 2016

I checkout Travis report, the reason why it is failed, it might be it should execute composer update before composer install, for the version constraints is changed.

@pjedrzejewski pjedrzejewski added the Maintenance CI configurations, READMEs, releases, etc. label Jun 17, 2016
@michalmarcinkowski
Copy link
Contributor

You should run composer update payum/payum payum/payum-bundle yourself. It will update the composer.lock file and the Travis will install proper versions.

@pamil
Copy link
Contributor

pamil commented Jun 17, 2016

@michalmarcinkowski we ignore composer.lock files from packages, so it won't have any effect.

@videni it looks like some package is missing, both composer install / composer update say so (btw. composer install without composer.lock file should work exactly as composer update - if not, that's an issue for Composer):

screen shot 2016-06-17 at 10 26 03

@pamil
Copy link
Contributor

pamil commented Jun 17, 2016

All right, it seems like php-http/client-implementation is a virtual package, we should add some package that implements it to require. For main Sylius/Sylius we use "php-http/guzzle6-adapter": "^1.1".

@michalmarcinkowski
Copy link
Contributor

@pamil I didn't notice it's a PayumBundle's composer.json :)

@videni videni force-pushed the patch-2 branch 2 times, most recently from 648ba3d to ff3df63 Compare June 17, 2016 10:00
@videni
Copy link
Contributor Author

videni commented Jun 19, 2016

Please merge this into master, or we can't update dependencies, composer will complain this error

[Symfony\Component\Config\Definition\Exception\InvalidConfigurationException]
Unrecognized option "factory" under "payum.gateways.offline"

@michalmarcinkowski
Copy link
Contributor

@videni could you rebase?

@videni videni force-pushed the patch-2 branch 3 times, most recently from 765b317 to d9056af Compare July 19, 2016 22:49
@videni
Copy link
Contributor Author

videni commented Jul 19, 2016

@michalmarcinkowski , this commit is rebased ,please check this branch again.

@michalmarcinkowski michalmarcinkowski added the BC Break PRs introducing BC breaks (do not even try to merge). label Jul 20, 2016
@michalmarcinkowski michalmarcinkowski merged commit b8f1faf into Sylius:master Jul 20, 2016
@michalmarcinkowski
Copy link
Contributor

Thanks! 👍

@videni videni deleted the patch-2 branch July 20, 2016 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BC Break PRs introducing BC breaks (do not even try to merge). Maintenance CI configurations, READMEs, releases, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants