[Documentation] Fixtures bundle #5286
Conversation
pamil
commented
Jun 17, 2016
pamil
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | bundle introduced in #5219, core fixtures in #5285 |
| License | MIT |
pamil
changed the title
pjedrzejewski
added
the
Documentation
| options: ~ # Fixture options | ||
|
|
||
| They implement ``Sylius\Bundle\FixturesBundle\Fixture\FixtureInterface`` and needs to be registered under | ||
| ``sylius_fixtures.fixture`` tag in order to be used in suite configuration. |
There was a problem hiding this comment.
Maybe it would be worthy to present some example definition of service? Code of class and declaration in services.xml. It is explained pretty well, but example can be helpful for beginners. Same for the listener.
There was a problem hiding this comment.
Upcoming in the next sections :)
There was a problem hiding this comment.
Custom fixture section added.
pamil
force-pushed
the
fixtures-bundle-documentation
branch
from
7f43da2
to
c1f9afe
Compare
pamil
force-pushed
the
fixtures-bundle-documentation
branch
from
c1f9afe
to
65adc94
Compare
|
|
||
| .. code-block:: yaml | ||
|
|
||
| <service id="app.fixture.country" class="AppBundle\Fixture\Country"> |
pamil
force-pushed
the
fixtures-bundle-documentation
branch
from
65adc94
to
5c59930
Compare
pamil
force-pushed
the
fixtures-bundle-documentation
branch
from
5c59930
to
a4b71ec
Compare
pamil
changed the title
pamil
force-pushed
the
fixtures-bundle-documentation
branch
from
a4b71ec
to
981b351
Compare
| priority: 0 # The higher priority is, the sooner the fixture will be executed | ||
| options: ~ # Fixture options | ||
|
|
||
| They implement ``Sylius\Bundle\FixturesBundle\Fixture\FixtureInterface`` and needs to be registered under |
There was a problem hiding this comment.
... the Sylius\Bundle\FixturesBundle\Fixture\FixtureInterface and need to be registered under the sylius_fixtures.fixture tag ...
|
|
||
| $this->countryManager->flush(); | ||
| } | ||
| } |
There was a problem hiding this comment.
Can you add docblocks in the examples? : D
There was a problem hiding this comment.
Not really, it will make listings unnecessarily longer and won't make anything clearer as those methods receives only typehinted parameters and usually does not return anything (except getName() which is quite straightforward).
|
Only some corrections of articles, plus docblocks in code examples - for me looks really fine, clear and understandable! :) 👍 |
|
Thank you for so many great suggestions @TheMadeleine! 🎉 |
|
Nice! Thank you. 👍 |
|
I agree about skipping docblocks and not sure about <?php tag, if Symfony skips it, I think we can safely do it too! |
