[JS] Upgrade a npm package version #5292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,6 +1,6 @@ | |||
| { | |||
| "name": "sylius", | |||
| "version": "0.17.0", | |||
| "version": "0.18.0", | |||
There was a problem hiding this comment.
Isn't it 0.19.0 on master right now? :)
There was a problem hiding this comment.
Right now we have 0.19.0-dev so it is not a 0.19.0 directly
|
I am pretty sure we should remove this and all other configurations which may suggest that this is a standalone package on NPM. We should only keep our requirements and that's it, wdyt? |
|
@pjedrzejewski it makes sense. I made this change, because I have just found a forgotten piece of code. 👍 for removal. |
|
@lchrusciel Could you do it in this PR? Thanks! |
|
sure, no problem |
|
Thanks Łukasz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper version in package.json file