[Bug Fix] ShippingCountryRuleChecker, Use the country configuration as a code, instead of it's id #5332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koemeet
changed the title
| @@ -56,9 +56,8 @@ function it_should_recognize_subject_as_not_eligible_if_country_does_not_match( | |||
| $subject->getShippingAddress()->willReturn($address); | |||
|
|
|||
| $countryRepository->findOneBy(['code' => 'IE'])->willReturn($country); | |||
| $country->getId()->willReturn(2); | |||
There was a problem hiding this comment.
It should be replaced by $country->getCode()->willReturn...
There was a problem hiding this comment.
maybe im stupid, but isnt this already at the top of this method? See: https://github.com/steffenbrem/Sylius/blob/dd619f287d67a3162709f2c2698c3785ff963c32/src/Sylius/Component/Core/spec/Promotion/Checker/ShippingCountryRuleCheckerSpec.php#L69
There was a problem hiding this comment.
@Zales0123 Could you confirm?
|
I just spotted this in promotions this morning, good job for fixing 👍 |
koemeet
force-pushed
the
bugfix/promotion-rule-shipping-country-code-fix
branch
from
dd619f2
to
c062c94
Compare
|
This one is rebased on latest master and ready too. |
|
Thanks! |
koemeet
restored the
bugfix/promotion-rule-shipping-country-code-fix
branch
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…-shipping-country-code-fix [Bug Fix] ShippingCountryRuleChecker, Use the country configuration as a code, instead of it's id
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This promotion rule is currently broken and ignored when used.