Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] Ability to disable assets / templates / translations overwriting support #5339

Merged
merged 2 commits into from
Jun 24, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jun 23, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets fixes #5113, removes classes parameters as discussed in #5001
License MIT

@pjedrzejewski
Copy link
Member

Nice! Although I am not sure about this support naming. We can and should do this for few more things in other bundles, so let's set some conventions. The most sensible term that comes to my mind now is "Feature Flags", but not perfect too... Any ideas, community? :)

BTW. Interesting bundle: https://github.com/DZunke/FeatureFlagsBundle.

@pamil
Copy link
Contributor Author

pamil commented Jun 24, 2016

Yep, that isn't the best name for that, but it isn't a typical feature flag, we only need to load specific services file or not. I'm open for suggestions though.

@pjedrzejewski pjedrzejewski merged commit db2c219 into Sylius:master Jun 24, 2016
@pjedrzejewski
Copy link
Member

Perfect, thanks!

@pamil pamil deleted the theme/disable-translator branch June 24, 2016 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ThemeBundle] Disable Translator
2 participants