[Resource] Fix resource loading / metadata #5371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
isometriks
commented
Jun 27, 2016
isometriks
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
isometriks
force-pushed
the
fix-resourceinterface
branch
from
0a1853a
to
2d3951d
Compare
isometriks
force-pushed
the
fix-resourceinterface
branch
from
2d3951d
to
890a209
Compare
|
Taken from #5233 @pjedrzejewski Let me know if I need to do anything else for this. Seems to be all working. |
| if (false === in_array($parent, $configuration->getMetadataDriverImpl()->getAllClassNames())) { | ||
| $parentMetadata = new ClassMetadata( | ||
| $parent, | ||
| $configuration->getNamingStrategy() |
There was a problem hiding this comment.
This was my only question. Do the tests check ODM as well? This line wasn't here before in ODM only in ORM
isometriks
changed the title
|
ping @sylius/core @pjedrzejewski |
|
Thank you Craig, nice work! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Fix resource loading / metadata
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Fix resource loading / metadata
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Fix resource loading / metadata
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Resource] Fix resource loading / metadata
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.