[Admin] Initial support for static content #5409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Jul 1, 2016
•
pamil
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | based on #5417 |
| License | MIT |
pamil
changed the title
pamil
force-pushed
the
admin/cmf-phpcr/static-content
branch
3 times, most recently
from
1c5555e
to
4323a15
Compare
pamil
force-pushed
the
admin/cmf-phpcr/static-content
branch
7 times, most recently
from
0178d80
to
eb6d8d7
Compare
pamil
changed the title
| /** | ||
| * @Then the static content :title should not be added | ||
| */ | ||
| public function theCurrencyShouldNotBeAdded($title) |
pamil
force-pushed
the
admin/cmf-phpcr/static-content
branch
from
eb6d8d7
to
eb4395e
Compare
|
Thanks Kamil! |
| use Webmozart\Assert\Assert; | ||
|
|
||
| /** | ||
| * @author Łukasz Chruściel <lukasz.chrusciel@lakion.com> |
There was a problem hiding this comment.
Nothing to be afraid of, that's a piece of really good code! :D
|
Won't it be worthy to split this implementation somehow from a default admin? I can imagine many cases, where somebody would like to take our admin, but manage a static content different way. |
|
I guess we can port the features from the old admin panel to the new one first and then think about making it an optional feature, there's much more to do in order to achieve that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.