[Documentation] Installation via composer #5414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CoderMaggie
commented
Jul 4, 2016
CoderMaggie
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | no |
| BC breaks? | no |
| Related tickets | partially #5275 |
| License | MIT |
pjedrzejewski
added
the
Documentation
Closed
| .. code-block:: bash | ||
|
|
||
| $ cd sylius # Move to the newly created directory | ||
| $ php app/console sylius:install |
There was a problem hiding this comment.
You need also a gulp call to see the shop. We should add a note that the following lines are require to present basic shop:
$ npm install
$ npm run gulpBTW should we think about adding it to sylius:install command?
There was a problem hiding this comment.
+1 for adding these commands, but not sure about including them in sylius:install - we will see. For now let's keep them separate.
There was a problem hiding this comment.
Maybe npm install could be run on composer post-install?
There was a problem hiding this comment.
The problem here is that if someone does not have npm installed, it will break the script.
CoderMaggie
force-pushed
the
docs/installation-via-composer
branch
from
7d97a83
to
c0f580f
Compare
|
Thanks Magda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.