[Shop] Change payment method on an order #5419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Jul 4, 2016
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | #5415 |
| License | MIT |
tuka217
force-pushed
the
thanks-payment
branch
6 times, most recently
from
0e262d1
to
fbd8de9
Compare
tuka217
changed the title
| @@ -910,6 +910,22 @@ public function iCompleteAddressingStepWithEmail($email, AddressInterface $addre | |||
| } | |||
|
|
|||
| /** | |||
| * @When I choose payment method :paymentMethodName | |||
| */ | |||
| public function iChoosePaymentMethod1($paymentMethodName) | |||
|
@tuka217 rebase required ;) And there is a typo in PR title |
tuka217
changed the title
| And I am redirected back to the order payment page | ||
| When I try to pay again with offline method | ||
| Then I should be redirected back to the thank you page | ||
| And I proceed selecting "PayPal Express Checkout" payment method |
tuka217
force-pushed
the
thanks-payment
branch
3 times, most recently
from
236ca85
to
7e929e7
Compare
tuka217
changed the title
tuka217
force-pushed
the
thanks-payment
branch
2 times, most recently
from
8a88962
to
ebf0c87
Compare
tuka217
changed the title
tuka217
force-pushed
the
thanks-payment
branch
2 times, most recently
from
154deb7
to
5106ee1
Compare
| @@ -32,4 +32,6 @@ public function mockCollaborator($className); | |||
| * @return MockInterface | |||
| */ | |||
| public function mockService($serviceId, $className); | |||
|
|
|||
| public function unmockAllServices(); | |||
There was a problem hiding this comment.
Is it needed? I think it has been removed eventually.
|
@tuka217 Last fixes + rebase and I think it'll be ready to go ;) |
Modify scenario about changing payment method on order
| @@ -881,6 +889,14 @@ private function createDefaultAddress() | |||
| } | |||
|
|
|||
| /** | |||
| * @Given I confirm my changes | |||
|
Thank you Ania, nice work! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Shop] Change payment method on an order
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.