[Behat] Add state transitions to creating orders programmatically #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Jul 6, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
| @@ -239,14 +245,15 @@ public function theCustomerChoseShippingWithPayment( | |||
|
|
|||
| $this->orderShipmentFactory->processOrderShipment($order); | |||
| $order->getShipments()->first()->setMethod($shippingMethod); | |||
|
|
|||
| $this->orderRecalculator->recalculate($order); | |||
|
|
|||
| $order->addPayment($payment); | ||
|
|
||
| $this->stateMachineFactory->get($order, OrderCheckoutTransitions::GRAPH)->apply(OrderCheckoutTransitions::TRANSITION_SELECT_PAYMENT); | ||
| $this->stateMachineFactory->get($order, OrderCheckoutTransitions::GRAPH)->apply(OrderCheckoutTransitions::TRANSITION_COMPLETE); |
There was a problem hiding this comment.
Maybe we could extract this all transitions calls to private method? Would be much cleaner:
private function applyTransition(OrderInterface $order, $transition)
{
$this->stateMachineFactory->get($order, OrderCheckoutTransitions::GRAPH)->apply($transition);
}wdyt?
GSadee
force-pushed
the
behat-order-transitions
branch
from
54a2549
to
2444090
Compare
|
*[Behat] Add state transitions to creating orders programmatically |
GSadee
force-pushed
the
behat-order-transitions
branch
from
2444090
to
0c08ccd
Compare
GSadee
changed the title
|
Thanks Grzesiu! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.