[Core][Payment] Populate gateway choices based on payum configuration #5442
Conversation
Zales0123
commented
Jul 6, 2016
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | |
| License | MIT |
| */ | ||
| public function __construct(array $gateways) | ||
| public function __construct(RegistryInterface $gatewaysRegistry) |
There was a problem hiding this comment.
Would be better to use GatewayRegistryInterface https://github.com/Payum/Payum/blob/master/src/Payum/Core/Registry/GatewayRegistryInterface.php
|
Pay attention to not all payum gateway could be used out of the box, some of them may require a special converter action. |
pjedrzejewski
added
Enhancement
| @@ -23,7 +23,8 @@ | |||
| "php": "^5.6|^7.0", | |||
|
|
|||
| "sylius/registry": "^0.19", | |||
| "sylius/resource": "^0.19" | |||
| "sylius/resource": "^0.19", | |||
| "payum/payum": "~1.0", | |||
|
Not sure sylius payment component must have a dependency on payum/core. So maybe we can introduce a new form type, payum specific. one can use it if both sylius/payment and payum/core are installed. The sylius/sylius could use payum specific by default It would be also better from BC point of view. @pjedrzejewski ping |
|
Definitely should not depend on Payum/Core. So I'd introduce a gateway choice type, that is replaced/populated with appropriate choices in PayumBundle. Ideally, entire glue between Sylius and Payum is in SyliusPayumBundle. And it should not be that hard, because only problem now is in the new Pay / After Pay actions on OrderController in Core. See #5415. Moving that to PayumBundle down the road should not be a problem. |
Zales0123
force-pushed
the
populate-gateway-choices-based-on-payum-configuration
branch
from
f4dbd33
to
7295370
Compare
|
Ok, so finally we end up with something much simpler 😄 We remove gateways configuration from |
| return; | ||
| } | ||
|
|
||
| $config = $container->getExtensionConfig('payum'); |
There was a problem hiding this comment.
this is not really accurate since some gateways could be added via container tag, or even stored in database.
There was a problem hiding this comment.
Sure they can. However this is just a prepend, gateways configuration can be easily overwritten in yml file, or in extension, or in any other possible way.
|
Thanks Mateusz! 👍 |
Zales0123
deleted the
populate-gateway-choices-based-on-payum-configuration
branch
