[Shop] Add ability to show static content #5452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Jul 6, 2016
pamil
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | - |
| License | MIT |
pamil
changed the title
| * @param ClassMetadata $class | ||
| * @param string $staticContentPath | ||
| */ | ||
| public function __construct(DocumentManagerInterface $dm, ClassMetadata $class, $staticContentPath) |
There was a problem hiding this comment.
To be consistent with parent implementation of __construct
pamil
force-pushed
the
shop/cmf/static-content/show
branch
2 times, most recently
from
c997243
to
ded197e
Compare
pamil
changed the title
pamil
force-pushed
the
shop/cmf/static-content/show
branch
from
ded197e
to
e69c777
Compare
| - sylius.behat.context.setup.static_content | ||
|
|
||
| - sylius.behat.context.ui.shop.static_content | ||
|
|
There was a problem hiding this comment.
Srsly? It just separates contexts from filters.
There was a problem hiding this comment.
Yup. Indention separates them enough. We don't have such a separation in any other suite.
| {% extends '@SyliusShop/layout.html.twig' %} | ||
|
|
||
| {% block content %} | ||
| {% createphp resource as='rdf' noautotag %} |
There was a problem hiding this comment.
We should not use createphp for new shop. Please remove it.
|
Thanks Kamil! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Shop] Add ability to show static content
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.