Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Channel] Enhance channel collector #5453

Merged
merged 3 commits into from
Jul 7, 2016
Merged

[Channel] Enhance channel collector #5453

merged 3 commits into from
Jul 7, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jul 6, 2016 •
edited
Loading

Q A
Bug fix? yes
New feature? yes
BC breaks? yes (renamed sylius_channel.fake_channel_support to sylius_channel.debug)
Related tickets -
License MIT

TODO:

  • Document BC break

@pjedrzejewski pjedrzejewski added DX Issues and PRs aimed at improving Developer eXperience. BC Break PRs introducing BC breaks (do not even try to merge). labels Jul 6, 2016
@pamil pamil force-pushed the enhancement/profiler-data-collectors branch from 73981d5 to 2c41470 Compare July 7, 2016 07:33
@pamil pamil force-pushed the enhancement/profiler-data-collectors branch from 2c41470 to 27016e7 Compare July 7, 2016 11:03
pjedrzejewski
pjedrzejewski reviewed Jul 7, 2016
View reviewed changes
UPGRADE.md

### ChannelBundle

* Renamed configuration option `sylius_channel.fake_channel_support` to `syliuc_channel.debug`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syliuc -> sylius

@pjedrzejewski pjedrzejewski merged commit 95a3697 into Sylius:master Jul 7, 2016
@pjedrzejewski
Copy link
Member

We will fix the typo when adding more to the upgrade, thanks!

@pamil pamil deleted the enhancement/profiler-data-collectors branch July 7, 2016 15:05
@pamil pamil mentioned this pull request Jul 8, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
BC Break PRs introducing BC breaks (do not even try to merge). DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pamil @pjedrzejewski