[GridBundle] Allow filtering by fields from associated objects #5501
Conversation
| $this->queryBuilder->andWhere($this->getFieldName($field).' =< :'.$field)->setParameter($field, $value); | ||
| $this->setParameter($field, $value); | ||
|
|
||
| $this->queryBuilder->andWhere($this->getFieldName($field).' =< :'.$field); |
|
@pjedrzejewski why this PR not merge? What do you think? |
| @@ -74,7 +74,7 @@ public function comparison($field, $operator, $value) | |||
| */ | |||
| public function equals($field, $value) | |||
| { | |||
| $this->queryBuilder->setParameter($field, $value); | |||
| $this->setParameter($field, $value); | |||
|
|
|||
| return $this->queryBuilder->expr()->eq($this->getFieldName($field), ':'.$field); | |||
There was a problem hiding this comment.
BUG: $field (':'.$field) still not replaced by _
There was a problem hiding this comment.
OOPS!! MY BAD!!
|
Build is failing, otherwise looks good! 👍 |
|
@pjedrzejewski The fail is about The problem is I do not want to apply any filter when form input of filter is not filled by user (e.g. filling only another field) because it will automatically only show data with empty strings! But on the other hand what to do if user really wants to filter empty strings? Should I not support filtering for empty strings? Or to add another field (checkbox) as |
|
The problems is that string filter type: empty / non-empty has no value - so your |
|
@pjedrzejewski Thanks for the feedback :) I think it's ready now |
|
Thanks Aram! Tests FTW! |
I also had some issues when filter form was submitting with empty string value so I thought maybe do not restrict DataSource when filer data is empty?!