[Order] Refactor order state machine #5516
Conversation
|
why has sequence/SequenceBundle been removed? |
GSadee
force-pushed
the
state-machine-order
branch
from
8486fb5
to
e2a3bf7
Compare
|
@bendavies it is a question to #5505. Sequence and SequenceBundle are going to be removed because of its redundancy. We were using it only to generate order number in only one specific case, so this simple logic should be in |
GSadee
force-pushed
the
state-machine-order
branch
from
e2a3bf7
to
af1973a
Compare
|
That doesn't negate the fact that it's a nice standalone component. demonstrated by the fact i was going to use it. I think it would be a shame. |
GSadee
force-pushed
the
state-machine-order
branch
4 times, most recently
from
bc4f71f
to
dc61169
Compare
GSadee
changed the title
| /** | ||
| * @author Grzegorz Sadowski <grzegorz.sadowski@lakion.com> | ||
| */ | ||
| class OrderNumberGenerator implements OrderNumberGeneratorInterface |
There was a problem hiding this comment.
This class could be final as well
GSadee
force-pushed
the
state-machine-order
branch
3 times, most recently
from
25d964b
to
7bb1265
Compare
|
@bendavies you can still use v0.19 of this component if you want to. We already have so many packages that we need to reduce it to minimum. We don't want to maintain this component as a generic and standalone, cause it's more overhead than benefit for us. |
GSadee
force-pushed
the
state-machine-order
branch
from
7bb1265
to
636c856
Compare
|
Thanks Grzesiu! |
|
|
||
| $this->objectManager->flush(); | ||
| } | ||
|
|
||
| /** | ||
| * @Given /^the customer confirmed (this order)$/ | ||
| * @Given /^the customer fulfilled (this order)$/ |
There was a problem hiding this comment.
This step will not be used.
Based on #5505