[BC Break] Unplug SyliusWebBundle and SyliusSearchBundle #5535
Conversation
GSadee
commented
Jul 19, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | |
| License | MIT |
michalmarcinkowski
added
the
BC Break
GSadee
force-pushed
the
unplug-web-and-search-bundle
branch
from
2ee5578
to
dfb6cb9
Compare
GSadee
force-pushed
the
unplug-web-and-search-bundle
branch
from
dfb6cb9
to
257619c
Compare
|
What about SearchBundle, guys? Any plans to bring it back before 1.0? |
GSadee
changed the title
| @@ -66,7 +65,7 @@ public function generate() | |||
|
|
|||
| foreach ($products as $product) { | |||
| $productUrl = $this->sitemapUrlFactory->createNew(); | |||
| $localization = $this->router->generate($product, [], true); | |||
| $localization = $this->router->generate('sylius_shop_product_show', ['slug' => $product->getSlug()], true); | |||
There was a problem hiding this comment.
This couples core with ShopBundle, but I will open a PR, which fixes that later.
|
Thanks Grzesiu! 👍 |
|
@okwinza ElasticSearch integration will come in a different form before 1.0, absolutely. But we do not want to support or maintain mysql based search indexing in Sylius itself. So this bundle needs to be removed, as much as I hate to say that. :/ |
|
This PR removed the template customization for the checkout: https://github.com/Sylius/Sylius/pull/5535/files#diff-900dfac95dd61a7259c479f8cc58b329L131 Is there another way to do this? |
|
@dantleech We will be working on checkout customization docs (/cc @TheMadeleine), but new checkout is mostly routing and state machine configuration, so you can easily customize the templates. See |
|
sounds good :) do you mean that I should override that route ( |
|
so just to be clear - the FlowBundle / CheckoutScenario is now redundant? |
|
@dantleech Yes... :) |
