[User] Change user bundle configuration to be able to support multipl… #5539

Arminek · 2016-07-19T14:13:08Z

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Related tickets	#5547
License	MIT

tuka217 · 2016-07-19T14:19:32Z

src/Sylius/Bundle/UserBundle/DependencyInjection/SyliusUserExtension.php

@@ -55,7 +55,7 @@ public function load(array $config, ContainerBuilder $container)
            ->getDefinition('sylius.form.type.customer')
            ->addArgument(new Reference('sylius.form.event_subscriber.add_user_type'))
        ;
-        
+


liverbool · 2016-07-19T23:34:50Z

What's the detail of this PR, I think I don't know the main idea of this.

Arminek · 2016-07-20T09:51:06Z

The main idea of this PR is to generate services per defined users. And have configuration similar to this

sylius_user:
    resources:
        admin:
            user:
                classes:
                    model: Sylius\Component\Core\Model\User
                    form:
                        default: Sylius\Bundle\CoreBundle\Form\Type\UserType
        shop:
            user:
                classes:
                    model: Sylius\Component\Core\Model\Customer
                    controller: Sylius\Bundle\CoreBundle\Controller\CustomerController

pamil · 2016-07-20T09:53:32Z

Btw. should customer be a user?

michalmarcinkowski · 2016-07-20T10:04:34Z

I believe @Arminek meant:

sylius_user:
    resources:
        admin:
            user:
                classes:
                    model: Sylius\Component\Core\Model\AdminUser
        shop:
            user:
                classes:
                    model: Sylius\Component\Core\Model\ShopUser

😉

pamil · 2016-07-20T10:07:39Z

That makes sense :)

pamil · 2016-08-09T12:44:33Z

src/Sylius/Bundle/UserBundle/spec/Provider/EmailProviderSpec.php

@@ -46,7 +47,7 @@ function it_should_extend_user_provider()

    function it_supports_sylius_user_model()
    {
-        $this->supportsClass(UserInterface::class)->shouldReturn(true);
+        $this->supportsClass(User::class)->shouldReturn(true);


it does not support some other model

…e entity [Behat] Separate security context & clean up [Core][User] replace unused services

lchrusciel · 2016-08-11T08:35:17Z

features/user/managing_customers/editing_administrator.feature

@@ -9,7 +9,7 @@ Feature: Editing an administrator
        And there is an administrator "Gareth Bale" identified by an email "bale@example.com" and a password "bale11"
        And I am logged in as "bale@example.com"

-    @ui @javascript
+    @todo


This feature is no longer supported 😉 but in near feature it will be 💃

…odel

pjedrzejewski · 2016-08-12T13:08:25Z

Really great work Arek, thanks a lot! :)

[User] Change user bundle configuration to be able to support multipl…

Arminek changed the title ~~[User] Change user bundle configuration to be able to support multipl…~~ [WIP][User] Change user bundle configuration to be able to support multipl… Jul 19, 2016

tuka217 reviewed Jul 19, 2016
View reviewed changes

Arminek force-pushed the support-multiple-user-entity branch from c768685 to 97de80a Compare July 19, 2016 14:30

pjedrzejewski added the New Feature label Jul 20, 2016

Arminek force-pushed the support-multiple-user-entity branch 2 times, most recently from 242db22 to a43572c Compare August 2, 2016 08:27

Arminek force-pushed the support-multiple-user-entity branch 3 times, most recently from 46189ba to 7d3530b Compare August 4, 2016 15:50

Arminek changed the title ~~[WIP][User] Change user bundle configuration to be able to support multipl…~~ [User] Change user bundle configuration to be able to support multipl… Aug 9, 2016

pamil reviewed Aug 9, 2016
View reviewed changes

Arminek added 10 commits August 9, 2016 16:00

[User] Change user bundle configuration to be able to support multipl…

a9d9bd8

…e entity [Behat] Separate security context & clean up [Core][User] replace unused services

[User] Change services in user controller

7cce239

[Shop][User] Rename core user model to shop user

022ba0e

[Admin][User] Create admin model

1fae959

[User] Add email canonicalize field in doctrine schema

8dd4cba

[Behat][Security] Adjust security service

9fd9e60

[Core][User] Change user provider

1ca407d

[User] Refactor user providers

e0cc2e5

[User] Temporary work around

c2739db

[User] Crate new doctrine migration

63e8c65

Arminek force-pushed the support-multiple-user-entity branch from fcc3450 to 63e8c65 Compare August 9, 2016 14:00

Arminek added 3 commits August 9, 2016 19:31

[User][Core] Rename UserInterface with ShopUserInterface

82c8dbc

[User][Core] Adjust some core specs

060a301

[User][Core] Generate form subscribers per user type

32dbff0

lchrusciel reviewed Aug 11, 2016
View reviewed changes

Review fixes

db3ca6a

Arminek force-pushed the support-multiple-user-entity branch 2 times, most recently from 90f7bb3 to 8a463a2 Compare August 11, 2016 17:44

[Fixtures] Add admin fixtures and add authorization roles for admin m…

4b538a7

…odel

Arminek force-pushed the support-multiple-user-entity branch from 8a463a2 to 4b538a7 Compare August 11, 2016 18:25

pjedrzejewski merged commit 6ad017e into Sylius:master Aug 12, 2016

gorkalaucirica mentioned this pull request Aug 13, 2016

sylius:user:change-password = 'sylius_dev.sylius_shop_user' doesn't exist #5786

Closed

This was referenced Aug 16, 2016

[Admin] Crud for admin user #5797

Merged

[User] Get metadata definition from registry #5798

Merged

[WIP][User] Rework user commands #5800

Closed

lchrusciel mentioned this pull request Aug 16, 2016

The service “security.authentication.manager” has a dependency on a non-existent service “sylius.user_provider.name_or_email” #5796

Closed

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019

Merge pull request Sylius#5539 from Arminek/support-multiple-user-entity

1828a3e

[User] Change user bundle configuration to be able to support multipl…

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019

Merge pull request Sylius#5539 from Arminek/support-multiple-user-entity

24a3c38

[User] Change user bundle configuration to be able to support multipl…

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019

Merge pull request Sylius#5539 from Arminek/support-multiple-user-entity

e28b73c

[User] Change user bundle configuration to be able to support multipl…

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[User] Change user bundle configuration to be able to support multipl… #5539

[User] Change user bundle configuration to be able to support multipl… #5539

Arminek commented Jul 19, 2016 •

edited

Loading

tuka217 Jul 19, 2016

pamil Jul 19, 2016

liverbool commented Jul 19, 2016

Arminek commented Jul 20, 2016

pamil commented Jul 20, 2016

michalmarcinkowski commented Jul 20, 2016

pamil commented Jul 20, 2016

pamil Aug 9, 2016

lchrusciel Aug 11, 2016

Arminek Aug 11, 2016 •

edited

Loading

pjedrzejewski commented Aug 12, 2016

[User] Change user bundle configuration to be able to support multipl… #5539

[User] Change user bundle configuration to be able to support multipl… #5539

Conversation

Arminek commented Jul 19, 2016 • edited Loading

tuka217 Jul 19, 2016

Choose a reason for hiding this comment

pamil Jul 19, 2016

Choose a reason for hiding this comment

liverbool commented Jul 19, 2016

Arminek commented Jul 20, 2016

pamil commented Jul 20, 2016

michalmarcinkowski commented Jul 20, 2016

pamil commented Jul 20, 2016

pamil Aug 9, 2016

Choose a reason for hiding this comment

lchrusciel Aug 11, 2016

Choose a reason for hiding this comment

Arminek Aug 11, 2016 • edited Loading

Choose a reason for hiding this comment

pjedrzejewski commented Aug 12, 2016

Arminek commented Jul 19, 2016 •

edited

Loading

Arminek Aug 11, 2016 •

edited

Loading