[Documentation] Concepts: Attributes #5608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
CoderMaggie
commented
Jul 26, 2016
CoderMaggie
commented
| Q | A |
|---|---|
| Doc fix? | yes |
| New docs? | yes |
| BC breaks? | no |
| Related tickets | partially #5275 |
| License | MIT |
|
|
||
| .. code-block:: php | ||
|
|
||
| // To assign Attributes to Products firstly you will need a factory for ProductAttributes |
There was a problem hiding this comment.
Wouldn't it be better to split this gargantuan blob of code into smaller ones and move descriptions (like the one above) before the code-blocks?
There was a problem hiding this comment.
+1, also the example is a bit wrong, as we add same attribute twice to a single product, which is not supported yet. Let's add a single attribute for now!
pjedrzejewski
added
the
Documentation
CoderMaggie
force-pushed
the
docs/attributes
branch
from
668c6f0
to
ddf2e4d
Compare
|
Thanks Magda! |
55 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.