[Behat][Shop] Added stock level dependant rendering of simple product's details page #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -114,7 +130,8 @@ protected function getDefinedElements() | |||
| { | |||
| return array_merge(parent::getDefinedElements(), [ | |||
| 'name' => '#sylius-product-name', | |||
| 'attributes' => '#sylius-product-attributes' | |||
| 'attributes' => '#sylius-product-attributes', | |||
| 'out-of-stock-label' => '#sylius-product-out-of-stock', | |||
There was a problem hiding this comment.
All of this elements are labels somehow. out-of-stock-label -> out-of-stock?
There was a problem hiding this comment.
No idea what do you mean in the first part 😄 , 👍 for the second one though.
NoResponseMate
force-pushed
the
stockpile-the-inventory
branch
from
61b2bde
to
c29fff5
Compare
NoResponseMate
changed the title
NoResponseMate
force-pushed
the
stockpile-the-inventory
branch
from
ddeccaa
to
ff1cd5a
Compare
NoResponseMate
changed the title
| @@ -294,6 +294,15 @@ public function iAddProductToTheCartSelectingVariant($variant, ProductInterface | |||
| } | |||
|
|
|||
| /** | |||
| * @When /^I add (\d+) of (them) to (the|my) cart$/ | |||
There was a problem hiding this comment.
(the|my) ->(?:the|my) - don't want to capture that phrase
pjedrzejewski
added
BC Break
|
|
||
| @ui | ||
| Scenario: Not being able to add a product to the cart when it is out of stock | ||
| Given the product "T-shirt banana" is not available at the moment |
There was a problem hiding this comment.
is not available at the moment this can be confusing because the product can be disabled, not available in the channel and probably few more, we should be more explicit e.g. the product "X" is out of stock
NoResponseMate
force-pushed
the
stockpile-the-inventory
branch
from
517d1a3
to
45a06a6
Compare
|
Good job Janek! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…tory [Behat][Shop] Added stock level dependant rendering of simple product's details page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[BC Break] - removal of
backordersflag from sylius configuration, most likely it's going to be brought back to life or replaced afterInventory's refactoring