Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Shop][Product] Viewing product's price #5617

Merged
merged 4 commits into from
Aug 2, 2016

Conversation

tuka217
Copy link
Contributor

@tuka217 tuka217 commented Jul 27, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets -
License MIT

@tuka217 tuka217 changed the title [Shop][Product] Viewing product's price on detailed page [WIP][Shop][Product] Viewing product's price on detailed page Jul 27, 2016
@@ -0,0 +1,14 @@
@viewing_products
Feature: Viewing a product price
In order to see products price
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't we using 4 spaces as indentation in other features?

@pjedrzejewski pjedrzejewski added New Feature Shop ShopBundle related issues and PRs. labels Jul 28, 2016
@tuka217 tuka217 force-pushed the product-price branch 6 times, most recently from afacb59 to 7eb1d53 Compare July 28, 2016 13:51
Given the store has a product "T-shirt watermelon" priced at "€19.00"
And this product belongs to "T-Shirt"
When I browse products from taxon "T-Shirts"
Then I should see the product "T-shirt banana" with price "€19.00"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might not be a professional biologist, but i'm quite certain that bananas are not watermelons.

@tuka217 tuka217 force-pushed the product-price branch 2 times, most recently from 4767f10 to aabc944 Compare July 28, 2016 14:45
And the store classifies its products as "T-Shirts"
And this product belongs to "T-Shirts"
When I browse products from taxon "T-Shirts"
Then I should see the product "T-shirt banana" with price "€19.00"
Copy link
Member

@lchrusciel lchrusciel Jul 28, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not really. banana -> watermelon

@tuka217 tuka217 force-pushed the product-price branch 3 times, most recently from 0794638 to 0ef32cc Compare July 29, 2016 09:06
@tuka217 tuka217 changed the title [WIP][Shop][Product] Viewing product's price on detailed page [Shop][Product] Viewing product's price on detailed page Jul 29, 2016
@tuka217 tuka217 changed the title [Shop][Product] Viewing product's price on detailed page [Shop][Product] Viewing product's price Jul 29, 2016
@@ -0,0 +1,16 @@
@viewing_products
Feature: Viewing a product price on products list
In order to see products price
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order to see the prices of listed products?

@pjedrzejewski pjedrzejewski merged commit 2473ce3 into Sylius:master Aug 2, 2016
@pjedrzejewski
Copy link
Member

Nice work Ania!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Shop ShopBundle related issues and PRs.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants