[ThemeBundle] fixed assets re-installation #5628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1 +1 @@ | |||
| Vanilla asset | |||
| Theme asset | |||
There was a problem hiding this comment.
These test were passing, "Vanilla asset" is used here to detect issues with theme assets loading. If we're using a theme and "Vanilla asset" shows, then something is wrong with the codebase, not with tests.
There was a problem hiding this comment.
Or just tests were wrong and in fact only the RELATIVE_SYMLINK was used so they were passing because of that. If so, AssetsInstaller needs a fix.
There was a problem hiding this comment.
hey, I should have made that WIP :) and yeah you are right.
takeit
changed the title
fixed tests fixed assets re-installation and added more tests
takeit
changed the title
|
Thanks Rafał! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue when you want to update your assets once they were already installed at least one time. Let's say I have installed assets, I edit one of the asset files in my theme and run
sylius:theme:assets:installcommand again - the updated asset file won't be copied over to thewebdirectory, thus I still get the old version.