[Inventory] Remove backorders & available on demand support, add tracking toggle on Stockable #5650
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
inventory/remove-backorders-support
branch
2 times, most recently
from
cd9f3a0
to
735ebaa
Compare
pjedrzejewski
added
the
BC Break
pamil
force-pushed
the
inventory/remove-backorders-support
branch
2 times, most recently
from
91d5257
to
94eba03
Compare
pamil
changed the title
| @@ -52,9 +38,9 @@ Normally, inventory units are created automatically by Sylius and you do not nee | |||
| use Sylius\Component\Inventory\Model\InventoryUnitInterface; | |||
|
|
|||
| $variant = // Get variant from product. | |||
| $inventoryUnits = $this->get('sylius.inventory_unit_factory')->create($variant, 6, InventoryUnitInterface::STATE_BACKORDER); | |||
| $inventoryUnits = $this->get('sylius.inventory_unit_factory')->create($variant, 6, InventoryUnitInterface::STATE_RETURNED); | |||
There was a problem hiding this comment.
We do not support returns out of the box, so the state should be different.
Btw. this state should be completely removed.
pamil
force-pushed
the
inventory/remove-backorders-support
branch
2 times, most recently
from
75f17d6
to
9cbd6a8
Compare
pamil
force-pushed
the
inventory/remove-backorders-support
branch
from
9cbd6a8
to
290b402
Compare
| "php": "^5.6|^7.0", | ||
|
|
||
| "sylius/resource": "^1.0" | ||
| "php": "^5.6|^7.0" |
There was a problem hiding this comment.
Yes, we don't need sylius/resource any more.
|
Thanks Kamil! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily removing backorders & available on demand support - will rewrite it soon (with scenarios 🎉), adding tracking toggle on stockable.