Remove WebBundle #5655
Merged
Remove WebBundle #5655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pamil
force-pushed
the
remove/web-bundle
branch
2 times, most recently
from
dfd7718
to
1577710
Compare
| @@ -1,4 +1,4 @@ | |||
| {% extends 'SyliusWebBundle:Frontend:layout.html.twig' %} | |||
| {% extends 'SyliusShopBundle::layout.html.twig' %} | |||
There was a problem hiding this comment.
We should not couple PayumBundle with ShopBundle
There was a problem hiding this comment.
👍 - nevertheless I'm just moving the PayumBundle coupling from WebBundle to ShopBundle, it should be fixed in another PR.
pamil
force-pushed
the
remove/web-bundle
branch
from
1577710
to
41eaffd
Compare
pamil
force-pushed
the
remove/web-bundle
branch
from
41eaffd
to
c4a4626
Compare
|
Thank you Kamil! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not used anymore, but still annoying during some refactorings.