[Shop][Payment] Prevent selecting payment method not assigned to channel #5689
Conversation
tuka217
commented
Aug 3, 2016
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | - |
| License | MIT |
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function findEnabledForChannel(ChannelInterface $channel) |
There was a problem hiding this comment.
Why won't we just use $channel->getPaymentMethods() collection? It implements Doctrine\Common\Collections\Selectable, so:
$channel->getPaymentsMethods()->matching(new Criteria(new Comparison('enabled', Comparison::EQ, true)))Should work even faster (we won't need to hydrate all the payment methods only to pass them to another query).
There was a problem hiding this comment.
Then we would not need this custom repository, we can use it directly in the resolver or implement on the model - see http://docs.doctrine-project.org/projects/doctrine-orm/en/latest/reference/working-with-associations.html#filtering-collections.
There was a problem hiding this comment.
Of course the typehint is oversimplified now, it's either ArrayCollection (if created manually) or PersistentCollection (if hydrated by Doctrine), but both of them implements Collection and Selectable.
There was a problem hiding this comment.
In current implementation it cannot be done in this way.
tuka217
force-pushed
the
payment-method-per-channel
branch
from
0fe018d
to
1ecf79a
Compare
tuka217
force-pushed
the
payment-method-per-channel
branch
3 times, most recently
from
8593dbc
to
322fbae
Compare
| use Sylius\Component\Core\Model\ChannelInterface; | ||
| use Sylius\Component\Resource\Repository\RepositoryInterface; | ||
| use Sylius\Component\Payment\Repository\PaymentMethodRepositoryInterface as BasePaymentMethodRepositoryInterface; | ||
| /** |
tuka217
force-pushed
the
payment-method-per-channel
branch
from
322fbae
to
e6dc95f
Compare
…signed to channel
tuka217
force-pushed
the
payment-method-per-channel
branch
from
e6dc95f
to
33d8cd8
Compare
…toryInterface [CoreBundle] Add implementation for method from PaymentMethodRepositoryInterface Add implementation of scenario
tuka217
force-pushed
the
payment-method-per-channel
branch
from
33d8cd8
to
0e3af9e
Compare
|
Thank you Ania! :) |
[Shop][Payment] Prevent selecting payment method not assigned to channel
