Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API][Zone] Zone API tests #5728

Merged
merged 6 commits into from
Aug 8, 2016
Merged

Conversation

Zales0123
Copy link
Member

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets
License MIT

@Zales0123 Zales0123 changed the title Zone api test [API][Zone] Zone API tests Aug 8, 2016
@lchrusciel
Copy link
Member

👍 Can be added in separate PR, but we can think about some custom validation, like what would happen if we sent some strange type during creation.

@pjedrzejewski pjedrzejewski merged commit e98a8e8 into Sylius:master Aug 8, 2016
@pjedrzejewski
Copy link
Member

Thanks Mateusz! We need to remove the type from the endpoints in the next iteration. It should use a form type that has "type" field enabled. Then the type can be passed as part of the request content and not in the url.

@Zales0123
Copy link
Member Author

@pjedrzejewski I've thought about it, but it also require some changes about zone members collection (now it takes 'zone_type' => $zoneType option). Nevertheless - 👍

@Zales0123 Zales0123 deleted the zone-api-test branch October 6, 2016 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants