[Admin] [Customer]Remove delete button on index, add information about no account on show page #5729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Aug 8, 2016
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | - |
| License | MIT |
| @@ -24,3 +24,13 @@ Feature: Sign in to the store | |||
| And I log in | |||
| Then I should be notified about bad credentials | |||
| And I should not be logged in | |||
|
|
|||
| @todo | |||
| Scenario: A customer cannot log in after deleting their account | |||
There was a problem hiding this comment.
after his account was deleted?
There was a problem hiding this comment.
- Cannot log in after my account deletion/removal
- Cannot log in after my account was deleted ?
There was a problem hiding this comment.
Second one 👍. The first one may suggest that it was deleted by the customer himself. :)
tuka217
force-pushed
the
remove-button-customer
branch
from
3e2eab8
to
f2b54e1
Compare
tuka217
changed the title
| @@ -22,3 +22,8 @@ Feature: Seeing customer's details | |||
| When I view details of the customer "f.baggins@shire.me" | |||
| Then his shipping address should be "Frodo Baggins, Bag End, Hobbiton, NEW ZEALAND 1" | |||
| And his billing address should be "Bilbo Baggins, The Last Homely House, Rivendell, NEW ZEALAND 7" | |||
|
|
|||
| @ui | |||
| Scenario: Seeing information about no existing account for given customer | |||
…r not being able to log in after account removal [AdminBundle] Remove delete button from customer index page
[Behat] Add implementation of scenarios
tuka217
force-pushed
the
remove-button-customer
branch
from
f2b54e1
to
85f15ec
Compare
|
Thanks Ania! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Admin] [Customer]Remove delete button on index, add information about no account on show page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.