[Gulp] Clean up Sylius gulp files #5748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .pipe(livereload()) | ||
| gulp.task('admin', function() { | ||
| gulp.src('src/Sylius/Bundle/AdminBundle/Gulpfile.js', { read: false }) | ||
| .pipe( chug() ) |
There was a problem hiding this comment.
Can we do not surround chug() with spaces? :)
pjedrzejewski
added
UX
Zales0123
force-pushed
the
clean-up-sylius-gulps
branch
2 times, most recently
from
332cf48
to
3e5a3f7
Compare
Zales0123
force-pushed
the
clean-up-sylius-gulps
branch
from
3e5a3f7
to
079118c
Compare
Zales0123
changed the title
|
Thanks Mateusz! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Gulp] Clean up Sylius gulp files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should deeply consider gulp files structure in Sylius. First step could be splitting
Gulpfile.jsinto ShopBundle and AdminBundle, that would allow us to easily install only needed assets (again - superuseful for Sylius-Standard).