-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Order] Order exchange rate #5804
Conversation
Arminek
commented
Aug 16, 2016
Q | A |
---|---|
Bug fix? | no |
New feature? | no |
BC breaks? | no |
Related tickets | #5738 |
License | MIT |
[CoreBundle][MoneyBundle] Pass exchange rate to PriceHelper
@@ -193,7 +216,7 @@ private function provideCurrency($currencyCode) | |||
$currency = $this->currencyRepository->findOneBy(['code' => $currencyCode]); | |||
if (null === $currency) { | |||
/** @var CurrencyInterface $currency */ | |||
$currency = $this->createCurrency($currencyCode, mt_rand(0, 200) / 100); | |||
$currency = $this->createCurrency($currencyCode, mt_rand(0, 200) / 100); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wasn't it good?
@@ -0,0 +1,32 @@ | |||
@customer_account | |||
Feature: Viewing details of an order |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Viewing summary of an order placed in currency different than base
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also filename should match the feature title.
Thank you Arek and Ania! :) |
[Order] Order exchange rate
[Order] Order exchange rate
[Order] Order exchange rate