[Behat] Changed sample data to correspond with default configuration #5811
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Aug 17, 2016
•
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | fixes #5707 |
| License | MIT |
- Moved sample store to United States
- Exchanged Euros with Dollars
- Scenarios logic clean-ups
NoResponseMate
force-pushed
the
behat/critical-fix
branch
3 times, most recently
from
ef72ae0
to
332d17c
Compare
NoResponseMate
changed the title
NoResponseMate
force-pushed
the
behat/critical-fix
branch
from
332d17c
to
132bad4
Compare
| @@ -40,10 +40,10 @@ Feature: Zone validation | |||
| Scenario: Seeing a disabled type field when adding country type zone | |||
| Given I want to create a new zone consisting of country | |||
| Then the type field should be disabled | |||
| And it should be country type | |||
| And it should be of country type | |||
There was a problem hiding this comment.
Are you sure about this change?
NoResponseMate
force-pushed
the
behat/critical-fix
branch
2 times, most recently
from
762a6b2
to
e1c798a
Compare
NoResponseMate
force-pushed
the
behat/critical-fix
branch
from
e1c798a
to
5765964
Compare
|
Thank you Jasiek, really nice work! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.