-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Checkout][Inventory] Verify complete checkout #5882
[Checkout][Inventory] Verify complete checkout #5882
Conversation
Arminek
commented
Aug 24, 2016
Q | A |
---|---|
Bug fix? | no |
New feature? | yes |
BC breaks? | no |
Related tickets | #5872 |
License | MIT |
And I select "Free" shipping method | ||
And I complete the shipping step | ||
And I choose "Offline" payment method | ||
When product "Iron Maiden T-Shirt" quantity is changed to 3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't get it. This scenario does not have sense to me. You had 5 of 5 t-shirts in a cart, and just before confirmation, you have reduced stock to 3(so 2 of them left) and then you see I should be notified that this product does not have sufficient stock
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This scenario cover something like this when customer is already in the middle of checkout process and for example some other customer has already bought the same product.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sentence is really confusing.
But other customer has bough 2 products by this time
?
59bf4e0
to
238b7d6
Compare
238b7d6
to
3dfb01b
Compare
Thanks Arek! :) |
As @michalmarcinkowski said, you can have a look at the InStock validation constraint and do a quick refactoring. ;) |
[Checkout][Inventory] Verify complete checkout