Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Checkout][Inventory] Verify complete checkout #5882

Merged
merged 5 commits into from
Aug 29, 2016

Conversation

Arminek
Copy link
Contributor

@Arminek Arminek commented Aug 24, 2016

Q A
Bug fix? no
New feature? yes
BC breaks? no
Related tickets #5872
License MIT

And I select "Free" shipping method
And I complete the shipping step
And I choose "Offline" payment method
When product "Iron Maiden T-Shirt" quantity is changed to 3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't get it. This scenario does not have sense to me. You had 5 of 5 t-shirts in a cart, and just before confirmation, you have reduced stock to 3(so 2 of them left) and then you see I should be notified that this product does not have sufficient stock

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This scenario cover something like this when customer is already in the middle of checkout process and for example some other customer has already bought the same product.

Copy link
Member

@lchrusciel lchrusciel Aug 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence is really confusing.
But other customer has bough 2 products by this time?

@pjedrzejewski
Copy link
Member

Thanks Arek! :)

@pjedrzejewski
Copy link
Member

As @michalmarcinkowski said, you can have a look at the InStock validation constraint and do a quick refactoring. ;)

pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
[Checkout][Inventory] Verify complete checkout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants