[Checkout] Ensured exchange rate gets updated throughout checkout #5900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Aug 26, 2016
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Related tickets | - |
| License | MIT |
NoResponseMate
force-pushed
the
checkout/exchange-rate-update
branch
2 times, most recently
from
4ba747b
to
1ed2faa
Compare
NoResponseMate
force-pushed
the
checkout/exchange-rate-update
branch
2 times, most recently
from
fa1317e
to
131e3ac
Compare
| sylius_update_exchange_rate: | ||
| on: ["select_payment"] | ||
| do: ["@sylius.updater.order.exchange_rate_and_currency", "update"] | ||
| args: ["object"] |
There was a problem hiding this comment.
Do we need this?
There was a problem hiding this comment.
Until #5847 gets merged unfortunately it is necessary, otherwise after the select_payment transition the cart currency code and exchange rate reset to the default values.
NoResponseMate
force-pushed
the
checkout/exchange-rate-update
branch
from
131e3ac
to
8bc158d
Compare
| $this->selectPaymentPage, | ||
| $this->selectShippingPage, | ||
| $this->completePage, | ||
| $this->thankYouPage, |
There was a problem hiding this comment.
This should not be the case, hm?
There was a problem hiding this comment.
Welp, it's a possibility nonetheless 😄
NoResponseMate
force-pushed
the
checkout/exchange-rate-update
branch
from
8bc158d
to
fc5aab1
Compare
NoResponseMate
force-pushed
the
checkout/exchange-rate-update
branch
from
fc5aab1
to
31ccadd
Compare
|
Thanks Janek! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ate-update [Checkout] Ensured exchange rate gets updated throughout checkout
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ate-update [Checkout] Ensured exchange rate gets updated throughout checkout
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.