[Account] Subscribe to the newsletter in customer account #5918
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Aug 30, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | |
| License | MIT |
GSadee
changed the title
| @@ -76,6 +76,22 @@ public function saveChanges() | |||
| /** | |||
| * {@inheritdoc} | |||
| */ | |||
There was a problem hiding this comment.
Why do we need a {@inheritdoc} if there is no docblock in interface?
| /** | ||
| * {@inheritdoc} | ||
| */ | ||
| public function isNewsletterSubscription() |
There was a problem hiding this comment.
isSubscribedToNewsletter? (we can skip "The")
protected $subscribedToNewsletter = false;
|
@GSadee Nice, please tweak the field name and it is good to go! |
GSadee
force-pushed
the
subscribe-newsletter
branch
from
754f5ea
to
701139d
Compare
|
Thank you Grzesiu! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.