Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] Checked if the shipment confirmation email gets sent #5932

Merged
merged 2 commits into from
Aug 31, 2016

Conversation

NoResponseMate
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? yes
Related tickets -
License MIT

Based on #5912

@ui @email
Scenario: Receiving a welcoming email after registration
When I register with email "ghastly@bespoke.com" and password "suitsarelife"
Then I should be notified that new account has been successfully created
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a new account

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd go with my account as it's an I register scenario. WDYT?

Scenario: Finalizing order's shipment
Given I view the summary of the order "#00000666"
When specify its tracking code as "#00044"
And I ship this order
Then I should be notified that the order's shipment has been successfully shipped
Then I should be notified that the order has been successfully shipped
And an email with shipment's details of order "#00000666" should be sent to "lucy@teamlucifer.com"
Copy link
Contributor

@michalmarcinkowski michalmarcinkowski Aug 31, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

... of this order "# 00000666" ...

$this->assertEmailContainsMessage($order->getLastShipment()->getMethod()->getName());

$tracking = $this->sharedStorage->get('tracking_code');
$this->assertEmailContainsMessage($tracking);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we could squash it to the single check? Your order %number% has been shipped using %method%. You can check it's location with the "%tracking%" tracking code.

@NoResponseMate NoResponseMate changed the title [WIP][Behat] Checked if the shipment confirmation email gets sent [Behat] Checked if the shipment confirmation email gets sent Aug 31, 2016
@michalmarcinkowski michalmarcinkowski merged commit f12de71 into Sylius:master Aug 31, 2016
@michalmarcinkowski
Copy link
Contributor

Nice work Janek! Please apply my comments in a separate PR.

@NoResponseMate NoResponseMate deleted the email/order-shipped branch September 3, 2016 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants