[Inventory] Decrease quantity of items when order is paid #5935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Aug 31, 2016
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | #5870 |
| License | MIT |
| { | ||
| $indexOfVariant = $product->getVariants()->indexOf($variant); | ||
| $product->getVariants()->get($indexOfVariant)->setTracked(true); | ||
| $product->getVariants()->get($indexOfVariant)->setOnHand($quantity); |
There was a problem hiding this comment.
We should use already existing transformer to obtain specific variant of a specific product. Then we can simply do:
$variant->setTracted(true);
$variant->setOnHand($quantity);
GSadee
force-pushed
the
decrease-quantity
branch
3 times, most recently
from
3f124e9
to
804c13d
Compare
GSadee
force-pushed
the
decrease-quantity
branch
from
804c13d
to
677233f
Compare
| */ | ||
| public function theCustomerBoughtSeveralProducts($quantity, ProductInterface $product) | ||
| { | ||
| $this->addProductVariantToOrder($this->variantResolver->getVariant($product), $product->getPrice(), $quantity); | ||
| $variant = $this->variantResolver->getVariant($product); | ||
| $this->addProductVariantToOrder($variant, $product->getPrice(), $quantity); |
There was a problem hiding this comment.
$product->getPrice() -> $variant->getPrice()
|
Thank you Ania and Grzegorz! Please apply my comments in a separate PR. |
| And the product "T-shirt banana" has "Yellow" variant priced at "€20.54" | ||
| And the product "T-shirt banana" has "Green" variant priced at "€5.54" | ||
| And there are 5 items of "Yellow" variant of product "T-shirt banana" available in the inventory | ||
| And there are 5 items of "Green" variant of product "T-shirt banana" available in the inventory |
There was a problem hiding this comment.
...there are 5 units items... (see #5934)
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Inventory] Decrease quantity of items when order is paid
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.