Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Theme] Twig loader quick fix to avoid profiler exception #5958

Merged

Conversation

Zales0123
Copy link
Member

@Zales0123 Zales0123 commented Sep 2, 2016

Q A
Bug fix? yes
New feature? yes
BC breaks? yes
Related tickets fixes #5886
License MIT

@pjedrzejewski pjedrzejewski merged commit 10ecfe9 into Sylius:master Sep 5, 2016
@pjedrzejewski
Copy link
Member

Nice, thanks Mateusz! :)

@tchapi
Copy link
Contributor

tchapi commented Sep 12, 2016

This breaks templating ... and Twig_ExistsLoaderInterface is deprecated since 1.12.

Apart from the deprecation, wouldn't something like that be a bit better for now ? At least not BC breaking things :

try {
    return stat($this->findTemplate($name)) !== false;
} catch (\Exception $exception) {
    return false;
}

@ahilles107
Copy link
Contributor

👍 for @tchapi chapi solution. We really need to check if this file exists there. It breaks default fallback for error.html.twig template in error pages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Theme] Exception tab at symfony profiler doesn't work
4 participants