Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Concepts: Taxation #5962

Merged
merged 1 commit into from
Sep 9, 2016

Conversation

CoderMaggie
Copy link
Member

Q A
Doc fix? yes
New docs? no
BC breaks? no
Related tickets partially #5275
License MIT

@CoderMaggie CoderMaggie force-pushed the docs/taxation branch 4 times, most recently from 3dcd258 to 81d5459 Compare September 6, 2016 09:35
@CoderMaggie CoderMaggie changed the title [WIP] [Documentation] Concepts: Taxation [Documentation] Concepts: Taxation Sep 6, 2016
If you have a TaxCategory with a 10% TaxRate *includedInPrice*, then the price shown on the ProductVariant in that
TaxCategory will be increased by 10% all the time.

If the TaxRate *will not be included* the the price of ProductVariant will be shown without taxes, but when this
Copy link
Contributor

@tuka217 tuka217 Sep 7, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the TaxRate will not be included then the (...)

@pjedrzejewski
Copy link
Member

@TheMadeleine We should add one last thing: setting TaxCategory on ProductVariant. :)

@pjedrzejewski pjedrzejewski added the Documentation Documentation related issues and PRs - requests, fixes, proposals. label Sep 9, 2016
@pjedrzejewski pjedrzejewski merged commit 3c0c2c7 into Sylius:master Sep 9, 2016
@pjedrzejewski
Copy link
Member

Thank you Magda! :)

@CoderMaggie CoderMaggie deleted the docs/taxation branch October 4, 2016 07:21
@Mrkisha
Copy link

Mrkisha commented Oct 11, 2016

Hi,

I have used TaxationBundle outside of Sylius. Would like to contribute to documentation as the existing docs are very hard to follow. This of course goes for using this bundle outside Sylius. I've never contributed to Open Source Software and I would need a little help as well.

@CoderMaggie
Copy link
Member Author

Hi @Mrkisha ! Really happy to hear that! :) What help do you exactly need?

I would suggest reading this guide first :)

@Mrkisha
Copy link

Mrkisha commented Oct 17, 2016

@TheMadeleine Ok, so I made a pull request. Was confused how to go with docs, should I have changed the existing or should I have added another page to it and write how I implemented the bundle. So, I went with later. #6441 All comments are welcome.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Documentation related issues and PRs - requests, fixes, proposals.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants