[Promotion] Use proportional distribution in order percentage discount #5976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Sep 5, 2016
pamil
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | - |
| License | MIT |
|
We should add more scenarios here. The order percentage discount should also take into account shipping fee. |
| $itemsTotal = []; | ||
| foreach ($subject->getItems() as $orderItem) { | ||
| $itemsTotal[] = $orderItem->getTotal(); | ||
| } |
There was a problem hiding this comment.
There is getItemsTotal() method on Order
There was a problem hiding this comment.
It returns the sum of items totals, not the array with items totals.
|
@michalmarcinkowski there's "Receiving percentage discount does not affect the shipping fee" scenario, so we should rather discuss on it. |
|
@pamil that's great! I recall we simplified that, so you should configure shipping percentage discount separately. Good job then! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Promotion] Use proportional distribution in order percentage discount
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.