Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Settings] Do not inject container to ParameterTransformerListener #5991

Merged
merged 1 commit into from
Sep 6, 2016

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Sep 6, 2016

No description provided.

@michalmarcinkowski michalmarcinkowski merged commit b36ef82 into Sylius:master Sep 6, 2016
@michalmarcinkowski
Copy link
Contributor

👍

@pamil pamil deleted the parameter-transformer branch September 6, 2016 22:54
@bendavies
Copy link
Contributor

bendavies commented Sep 7, 2016

@pamil this is causing an error in my app after updating settings bundle.

  [Symfony\Component\DependencyInjection\Exception\ServiceCircularReferenceException]
  Circular reference detected for service "doctrine.dbal.default_connection", path: "doctrine.dbal.default_connection".

I imagine this is why the container was injected in the first place. Are you certain this does not break sylius when integrated? Will you consider reverting?

Thanks

@bendavies
Copy link
Contributor

I'm guessing one of my services somewhere must be made lazy...

@bendavies
Copy link
Contributor

I thought making my custom settings schema lazy would fix this (it has doctrine repository deps) but it doesn't work. if you ave any idea @pamil, let me know!

@pamil
Copy link
Contributor Author

pamil commented Sep 8, 2016

Ouch, that should be reverted indeed. Tests were passing, because SettingsBundle is no longer used in Sylius.

@bendavies
Copy link
Contributor

thanks @pamil what does sylius use for settings now?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants