[Admin][Order] Modifying a customer's shipping address on an order #6062
Conversation
GSadee
changed the title
GSadee
force-pushed
the
modifying-shipping-address
branch
from
ee088f4
to
fb41fd5
Compare
|
|
||
| @todo | ||
| Scenario: Modifying a customer's shipping address when the applied promotion is no longer valid | ||
| Given the promotion was disabled for the channel "Web" |
There was a problem hiding this comment.
why is it relevant to disable the promotion from the channel if the purchase was made - and the cart became an order?
There was a problem hiding this comment.
Because we want to be sure, that changing a shipping address on a placed order won't affect the order totals.
There was a problem hiding this comment.
so changing something on an order should not trigger the promotion calculator and get the totals changed, right? if so, then the promotion should still be active to testify that promotion calculator is not triggered on a shipping address change from admin.
maybe I'm missing something here.
There was a problem hiding this comment.
For 1.0 we deliver simple shipping address edit feature which will only modify the shipping address and leave the rest of the order untouched. That means the order will not be recalculated and this scenario covers situation when the promotion that was applied to an order is disabled after order was placed. It ensures the promotion is still applied to an order after shipping address modification and the totals are unchanged.
GSadee
force-pushed
the
modifying-shipping-address
branch
from
fb41fd5
to
0f86e10
Compare
GSadee
changed the title
GSadee
force-pushed
the
modifying-shipping-address
branch
2 times, most recently
from
ac721e1
to
d918aab
Compare
| */ | ||
| public function specifyShippingAddress($city, $street, $postcode, $country, $firstAndLastName) | ||
| { | ||
| $customerName = explode(' ', $firstAndLastName); |
There was a problem hiding this comment.
I would vote for $customerNames? Or sth like this, for sure a plural for as this variable contains an array not a single value.
|
|
||
| @ui | ||
| Scenario: Modifying a customer's shipping address when the applied coupon is no longer valid | ||
| Given the coupon "HOLIDAY" was used |
There was a problem hiding this comment.
... was used up to its usage limit
| And the store has "DHL" shipping method with "$20.00" fee within "EN" zone | ||
| And the store has a product "Suit" priced at "$400.00" | ||
| And there is a customer "mike@ross.com" that placed an order "#00000001" | ||
| And the customer have chosen to order in the "GBP" currency |
There was a problem hiding this comment.
I will fix it in a separate PR 👍
|
|
||
| Background: | ||
| Given the store operates on a single channel in "United States" | ||
| And the store ships everything for free within "US" zone |
There was a problem hiding this comment.
I will fix it in a separate PR 👍
| Given the store operates on a single channel in "United States" | ||
| And the store ships everything for free within "US" zone | ||
| And the store allows paying offline | ||
| And the store has "VAT" tax rate of 20% for "Suits" within "US" zone |
GSadee
force-pushed
the
modifying-shipping-address
branch
from
d918aab
to
ec7cd59
Compare
…g address on an order
GSadee
force-pushed
the
modifying-shipping-address
branch
from
ec7cd59
to
4a4c622
Compare
|
|
||
| Background: | ||
| Given the store operates on a single channel in the "United States" named "Web" | ||
| And that channel uses the "USD" currency by default |
There was a problem hiding this comment.
We should have step Given the store operates on a single channel in "United States" which will already create USD currency and make it a default currency of this channel.
There was a problem hiding this comment.
Yes, we have, but I wanted to clearly see what is our currency, because we modify it later.
|
|
||
| @ui | ||
| Scenario: Modifying a customer's shipping address when the applied promotion is no longer valid | ||
| Given the "VAT" tax rate is of 10% |
There was a problem hiding this comment.
Given the "VAT" tax rate has changed to 10%
GSadee
force-pushed
the
modifying-shipping-address
branch
from
4a4c622
to
fd8eb16
Compare
|
Nice work Grzesiu! 👍 |
This PR contains #6122