[Core] Remove all *.class parameters #6077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Sep 13, 2016
pamil
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Related tickets | partially #5001 |
| License | MIT |
pamil
force-pushed
the
core/inline-class-parameters
branch
from
f8b6f5c
to
b53e3fd
Compare
| @@ -14,7 +14,7 @@ | |||
| use Sylius\Bundle\ResourceBundle\Form\Type\AbstractResourceType; | |||
| use Symfony\Component\Form\FormBuilderInterface; | |||
|
|
|||
| class ImageType extends AbstractResourceType | |||
| abstract class ImageType extends AbstractResourceType | |||
There was a problem hiding this comment.
Why making this abstract?
There was a problem hiding this comment.
I've created new class ProductVariantImageType to avoid TaxonImageType extending ImageType (being the product variant one).
There was a problem hiding this comment.
Can't we have 3 types? sylius_image, sylius_product_variant_image and sylius_taxon_image?
There was a problem hiding this comment.
Removed that abstract, registering this one as sylius_product_variant_image. sylius_image has no meaning right now as we don't have a general model for images (just ProductVariantImage, TaxonImage, etc.).
pamil
force-pushed
the
core/inline-class-parameters
branch
3 times, most recently
from
025eeaf
to
1c49837
Compare
pamil
force-pushed
the
core/inline-class-parameters
branch
from
1c49837
to
55234be
Compare
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.