[Admin] Changed product code to variant code on orders show page #6128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Sep 15, 2016
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | no |
| Related tickets | fixes #6116 |
| License | MIT |
pamil
reviewed
Sep 15, 2016
| @@ -25,7 +25,8 @@ Feature: Seeing order item detailed data | |||
| Scenario: Seeing details of item in one row | |||
| Given I view the summary of the order "#00000666" | |||
| When I check "Iron Man T-Shirt" data | |||
| Then its unit price should be $39.00 | |||
| Then its code should be "IRON_MAN_T-SHIRT" | |||
There was a problem hiding this comment.
To verify this fix is correct we should add two variants of the same product and validate their codes.
NoResponseMate
force-pushed
the
fix/admin-order-product-variant-code
branch
from
58dad00
to
2d5091f
Compare
NoResponseMate
force-pushed
the
fix/admin-order-product-variant-code
branch
from
2d5091f
to
c9c9510
Compare
CoderMaggie
reviewed
Sep 23, 2016
| And it belongs to "T-Shirts" tax category | ||
| And the store has a product "Marvel T-Shirt" | ||
| And this product has "Iron Man T-Shirt" variant priced at "$49.00" | ||
| And this product has "Thor T-Shirt" variant priced at "$39.00" |
There was a problem hiding this comment.
Not in scope of this PR.
Besides most of our steps need a hardcore semantical rework
|
Thanks Janek! 👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…duct-variant-code [Admin] Changed product code to variant code on orders show page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.