Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ui] Fixed yes/no translations #6129

Merged
merged 1 commit into from
Sep 15, 2016

Conversation

NoResponseMate
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets -
License MIT

Should fix the 1/empty label rendering in admin's customer index. No way to test it without SyliusBot push crowdin and getting translations back. 😞

@michalmarcinkowski michalmarcinkowski merged commit f9d6543 into Sylius:master Sep 15, 2016
@michalmarcinkowski
Copy link
Contributor

Thanks Janek! Let's see what will happen :)

@michalmarcinkowski
Copy link
Contributor

Didn't work 😞 - #6132

@tchapi
Copy link
Contributor

tchapi commented Sep 16, 2016

It looks like a bug in Crowdin. I'd suggest replacing the "yes" and "no" keys by something like "ui_yes" and "ui_no" maybe ? Should work I guess ?

@NoResponseMate
Copy link
Contributor Author

@tchapi
My first thought, was to do something similar - yes_label and no_label, but first wanted to check if this would work. The only way to test was to create a PR so here we are 😄
Gonna follow up with a fix 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants