Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor AbstractDriver addFactory method #6158

Merged
merged 1 commit into from
Oct 17, 2016

Conversation

patrick-mcdougle
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
License MIT

Just noticed there was a little refactoring that could be done here to IMO make this more clear.

  • Eliminate early return
  • Remove code duplication

@patrick-mcdougle
Copy link
Contributor Author

@pjedrzejewski

@pjedrzejewski pjedrzejewski merged commit be23cb4 into Sylius:master Oct 17, 2016
@pjedrzejewski
Copy link
Member

Thanks Patrick!

@patrick-mcdougle patrick-mcdougle deleted the pmcd-refactors branch October 24, 2016 03:53
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Refactor AbstractDriver addFactory method
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants