Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security] Admin redirection fix #6171

Merged
merged 1 commit into from
Sep 21, 2016

Conversation

lchrusciel
Copy link
Member

@lchrusciel lchrusciel commented Sep 21, 2016

Q A
Bug fix? yes
New feature? no
BC breaks? no
Related tickets fixes #6168
License MIT

working without a slash
working with a slash

@michalmarcinkowski
Copy link
Contributor

Can we also remove exiting redirect root now?

sylius_admin_root:
    path: /
    defaults:
        _controller: FrameworkBundle:Redirect:redirect
        route: sylius_admin_dashboard
        permanent: true

@lchrusciel
Copy link
Member Author

lchrusciel commented Sep 21, 2016

@michalmarcinkowski is it connected to this PR? I have only adjusted a firewall.

@pamil
Copy link
Contributor

pamil commented Sep 21, 2016

@michalmarcinkowski shouldn't we put dashboard at / now?

@michalmarcinkowski michalmarcinkowski merged commit 1dcb7c7 into Sylius:master Sep 21, 2016
@michalmarcinkowski
Copy link
Contributor

michalmarcinkowski commented Sep 21, 2016

Thanks Łukasz! 👍

The admin root can be adjusted in a separate PR. Not sure why it was under /dashboard at the first place. Let's wait with this change for @pjedrzejewski.

@lchrusciel lchrusciel deleted the patch-1 branch October 5, 2016 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When not "admin-logged", /admin redirects to /login
4 participants