[Shop][UI] Fix styles path for the shop #6235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjedrzejewski
commented
Sep 28, 2016
pjedrzejewski
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Related tickets | fixes #X, partially #Y, mentioned in #Z |
| License | MIT |
pjedrzejewski
added
Bug Fix
Shop
pamil
reviewed
Sep 28, 2016
| @@ -23,7 +23,7 @@ var paths = { | |||
| ], | |||
| sass: [ | |||
| '../UiBundle/Resources/private/sass/**', | |||
There was a problem hiding this comment.
Will it work? With Sylius installed as single components (not sylius/sylius replacing all the other packages), the UiBundle will be at vendor/sylius/ui-bundle/ and ShopBundle at vendor/sylius/shop-bundle/.
There was a problem hiding this comment.
If you use Shop/Admin/Api, which all depend on Core, I think we won't recommend using them as standalone components and maybe we even remove their composer.json and recommend depending on sylius/sylius, which solves this and many other problems. Thoughts?
pamil
reviewed
Sep 28, 2016
| @@ -23,7 +23,7 @@ var paths = { | |||
| ], | |||
| sass: [ | |||
| '../UiBundle/Resources/private/sass/**', | |||
| 'ShopBundle/Resources/private/scss/**' | |||
| 'Resources/private/scss/**' | |||
There was a problem hiding this comment.
Side note: we have sass folder in UiBundle and scss here in ShopBundle.
There was a problem hiding this comment.
Yeah, I will clean this up when finalizing the UI.
|
👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…-styles [Shop][UI] Fix styles path for the shop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.